Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2596/1/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 109: if (glob_ret == GLOB_NOMATCH) { > how about combining this and L115-119 case by just putting this guard aroun Other possible errors are 'out of memory' and 'read error' -- To view, visit http://gerrit.cloudera.org:8080/2596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
