Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs() ......................................................................
IMPALA-3230: Spurious errors from DeleteOldLogs() DeleteOldLogs() uses glob to locate log files matching a given path. When glob returns an error, we log it, but since glob returns an error when no matching files are found, and since its common to have no matching files, eg. for uncommon logging levels like FATAL, this results in a significant amount of error logging for something that is not really an error. This patch updates DeleteOldLogs() to simply return when no matching log files are found. Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d Reviewed-on: http://gerrit.cloudera.org:8080/2596 Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/util/logging-support.cc 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
