Dan Hecht has posted comments on this change. Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs() ......................................................................
Patch Set 2: (1 comment) Code change looks good to me but please respond to Matt's question about testing. http://gerrit.cloudera.org:8080/#/c/2596/2/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 113: nit: this blank line doesn't help readability, delete it. -- To view, visit http://gerrit.cloudera.org:8080/2596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
