Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs() ......................................................................
IMPALA-3230: Spurious errors from DeleteOldLogs() DeleteOldLogs() uses glob to locate log files matching a given path. When glob returns an error, we log it, but since glob returns an error when no matching files are found, and since its common to have no matching files, eg. for uncommon logging levels like FATAL, this results in a significant amount of error logging for something that is not really an error. This patch updates DeleteOldLogs() to simply return when no matching log files are found. Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d --- M be/src/util/logging-support.cc 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/96/2596/2 -- To view, visit http://gerrit.cloudera.org:8080/2596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]>
