Henry Robinson has posted comments on this change.

Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS 
filesystem
......................................................................


Patch Set 11: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/1121/11//COMMIT_MSG
Commit Message:

Line 7: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem
Nit: please add a colon after IMPALA-1850


Line 10: as Default FS for Impala to run on.
default, not Default


Line 11: This patch configures Impala to use S3 as the default filesystem, 
rather
again, this is confusing because it makes it sound like S3 will always be the 
default filesystem. Instead, try:

"This patch configures Impala to use S3 as the default filesystem when it is 
enabled."


-- 
To view, visit http://gerrit.cloudera.org:8080/1121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 11
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Juan Yu <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: anujphadke <[email protected]>
Gerrit-HasComments: Yes

Reply via email to