anujphadke has posted comments on this change.

Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS 
filesystem
......................................................................


Patch Set 10:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/1121/10//COMMIT_MSG
Commit Message:

Line 7: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem
> nit:
Done


Line 9: .
> What are the supported filesystems? I think you mean supported filesystem *
Yes. I have rephrased it.


Line 9: impala
> Impala
Done


Line 10: S3
> I think this is better phrased as "This patch configures Impala to use S3 a
Done


http://gerrit.cloudera.org:8080/#/c/1121/10/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java
File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java:

Line 687: (
> you can remove these parentheses:
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/1121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 10
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Juan Yu <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: anujphadke <[email protected]>
Gerrit-HasComments: Yes

Reply via email to