Dan Hecht has posted comments on this change. Change subject: IMPALA-3292. Kudu scanner should not fail if KeepAlive request fails ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2708/1//COMMIT_MSG Commit Message: Line 7: . nit: IMPALA-3292: http://gerrit.cloudera.org:8080/#/c/2708/1/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: Line 438: scanner.KeepKuduScannerAlive(); seems like this could be simplified by rewriting the loop: while (!done_ && !added_to_queue) { added_to_queue = materialized_row_batches_->AddBatchWithTimeout(...); scanner.KeepKuduScannerAlive(); } then you always get the keep-alive after the AddBatchWithTimeout() call, so you don't need the "extra" call at 438, right? -- To view, visit http://gerrit.cloudera.org:8080/2708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ad2cfde3e50a4486d03f8dd763faac2eb4926a Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
