Dan Hecht has posted comments on this change. Change subject: IMPALA-3292. Kudu scanner should not fail if KeepAlive request fails ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2708/2/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: Line 433: scanner.KeepKuduScannerAlive(); > I couldn't figure out why the keep alive would be needed outside of the Add Its for the reason I alluded to in my earlier comment that suggested the rewrite -- it follows the call to AddBatchWithTimeout() for the very last iteration of the loop. In the old code, KeepKuduScannerAlive() is in the loop body so doesn't execute when added_to_queue becomes true. My earlier suggested rewrite (to patch 1) fixes that so that the special case KeepKuduScannerAlive() call can be removed. -- To view, visit http://gerrit.cloudera.org:8080/2708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ad2cfde3e50a4486d03f8dd763faac2eb4926a Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
