Casey Ching has posted comments on this change. Change subject: IMPALA-3292. Kudu scanner should not fail if KeepAlive request fails ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2708/2/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: Line 433: scanner.KeepKuduScannerAlive(); > Its for the reason I alluded to in my earlier comment that suggested the re Doesn't the keep alive gets called just as frequently in this patch though? It's just that the call happens unconditionally before AddBatch instead of unconditionally after. The window for the scanner to timeout should be the same. By calling before, the extra var isn't needed. -- To view, visit http://gerrit.cloudera.org:8080/2708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ad2cfde3e50a4486d03f8dd763faac2eb4926a Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
