Dan Hecht has posted comments on this change. Change subject: IMPALA-3292. Kudu scanner should not fail if KeepAlive request fails ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2708/2/be/src/exec/kudu-scan-node.cc File be/src/exec/kudu-scan-node.cc: Line 433: scanner.KeepKuduScannerAlive(); i think we want the KeepKuduScannerAlive() after the AddBatchWithTimeout() even if the add batch was successful because it may have still blocked for a while. that's what the old code was doing (it would always call AddBatchWithTimeout and then KeepKuduScannerAlive). -- To view, visit http://gerrit.cloudera.org:8080/2708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ad2cfde3e50a4486d03f8dd763faac2eb4926a Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
