Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism ......................................................................
Patch Set 1: (4 comments) A much needed patch, thanks for putting it out! http://gerrit.cloudera.org:8080/#/c/2769/1//COMMIT_MSG Commit Message: Line 9: On the client side, the wrapping is backwards: : SaslTransport(TBufferedTransport(socket)) We can rephrase this so it's more clear: On the client side, the wrapping of transports is the opposite of what it is on the server side: Client side: TSaslTransport(TBufferedTransport(socket)) Server side: TBufferedTransport(TSaslTransport(socket)) Line 18: You can conclude by saying: "This patch reorders the wrapping of transports in the thrift client, so that it matches the order on the thrift server" And maybe also add how this affects performance. http://gerrit.cloudera.org:8080/#/c/2769/1/be/src/rpc/thrift-client.h File be/src/rpc/thrift-client.h: Line 137: socker not your change, but change to "socket". Line 144: transport_ = socket_; : auth_provider_->WrapClientTransport(address_.hostname, transport_, service_name, : &transport_); Will this work fine if socket_ is NULL? -- To view, visit http://gerrit.cloudera.org:8080/2769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebcf6457091aef1fc0e5bd1549b3fcbafc5560d9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
