Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos 
mechanism
......................................................................


Patch Set 2:

(1 comment)

You previously mentioned in person that there were some random failures that 
you noticed in a kerberized setting. Was that related to this patch? Or just in 
general?

http://gerrit.cloudera.org:8080/#/c/2769/2/be/src/rpc/thrift-client.h
File be/src/rpc/thrift-client.h:

Line 146: &transport_
Can this just be &socket_, and get rid of L144 and make L150 as 
factory.getTransport(socket_)?


-- 
To view, visit http://gerrit.cloudera.org:8080/2769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcf6457091aef1fc0e5bd1549b3fcbafc5560d9
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to