Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2769/1/be/src/rpc/thrift-client.h File be/src/rpc/thrift-client.h: Line 144: transport_ = socket_; : auth_provider_->WrapClientTransport(address_.hostname, transport_, service_name, : &transport_); > Will this work fine if socket_ is NULL? Not sure what the expected behavior is if socket_ is NULL. It would make sense to fail the constructor and propagate and exception of some sort, yet I am not sure the code is meant to do that. -- To view, visit http://gerrit.cloudera.org:8080/2769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebcf6457091aef1fc0e5bd1549b3fcbafc5560d9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
