Dan Hecht has posted comments on this change. Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2769/2/be/src/rpc/thrift-client.h File be/src/rpc/thrift-client.h: Line 139 how could socket_ be not NULL here, given this is the constructor? what case was this worried about? Line 144: transport_ = socket_; is it okay that we now unconditionally set transport_ whereas the old code would only do that if socket_ != NULL? i.e. can we get in here with socket_ == NULL and transport_ != NULL? -- To view, visit http://gerrit.cloudera.org:8080/2769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebcf6457091aef1fc0e5bd1549b3fcbafc5560d9 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
