Alex Behm has posted comments on this change. Change subject: Kudu: Remove post merge TODOs that need no real work ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java File fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java: Line 118 There is some similarity with SingleNodePlanner.getNormalizedEqPred(). It might still be ok to remove this TODO, but please take a look first. http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java File fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java: Line 259: builder.add("-1"); // The API doesn't expose tablet row counts. The Kudu Client API .... http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java File fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java: Line 272 Imo removing this TODO is ok because I think we'd want to do this optimization in a more general fashion anyway. Please post a short comment on IMPALA-1788 that we should consider handling these kind of "impossible" predicates in the same way as constant folding. -- To view, visit http://gerrit.cloudera.org:8080/2807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
