Casey Ching has posted comments on this change. Change subject: Kudu: Remove post merge TODOs that need no real work ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2807/3/fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java File fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java: Line 24 > our normal response to hitting a (virtual) function in the backend that has There's no point in having this class if it's just going to produce runtime errors. Either the class can be rename to NoOpDdlDelegate and made clear that the desired behavior is a no-op. Or the class can be removed and previous users of the class can find some other way of doing nothing when no ddl delegate is needed. Do you have a preference? -- To view, visit http://gerrit.cloudera.org:8080/2807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
