Internal Jenkins has submitted this change and it was merged. Change subject: Kudu: Remove post merge TODOs that need no real work ......................................................................
Kudu: Remove post merge TODOs that need no real work Comments on files: 1) BinaryPredicate: The TODO was to create a more generic function but I couldn't find another place that needed something like this. 2) KuduTable: Addressed TOOD by adding comment to explain constant "-1". 3) UnsupportedOpDelegate: The TODO was to consider returning an error, I didn't see much benefit in doing that. 4) KuduScanNode: The TODO was to consider replacing a predicate with a literal "false", that's a fine suggestion but not particularly related to Kudu. It's just a general planner enhancement so I won't address that. Change-Id: I42c8120574def06727b645941bbf64cc69804120 Reviewed-on: http://gerrit.cloudera.org:8080/2807 Reviewed-by: Alex Behm <[email protected]> Tested-by: Internal Jenkins --- M fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java M fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java M fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java M fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java 4 files changed, 1 insertion(+), 9 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Internal Jenkins
