Marcel Kornacker has posted comments on this change. Change subject: Kudu: Remove post merge TODOs that need no real work ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2807/3/fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java File fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java: Line 24 > What do you mean by "return errors" and why would that be favorable? Are yo our normal response to hitting a (virtual) function in the backend that hasn't been implemented for a specific class yet is to return an error Status ("NYI"). this here does nothing. it should return an error (if you're calling an unsupported function, you need to find out about it), either as an error message or by throwing. -- To view, visit http://gerrit.cloudera.org:8080/2807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
