Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/5/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 367: bool ReadValueBatch(MemPool* pool, int max_values, int tuple_size, > In AssembleRows() we call Read*ValueBatch() on a ColumnReader* and not a co Ah I see, sorry, I didn't trace through all the virtual + overloaded non-virtual functions correctly :\ Thanks for the explanation. I agree this seems best, I can't think of a different way to do it. It might be more clear what's going on if you move this to CollectionColumnReader() and make the Read*ValueBatch() functions pure virtual, so it's more obvious that we always use a specialized function, but maybe that would be confusing in a different way. Up to you. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
