Alex Behm has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs ......................................................................
Patch Set 2: (4 comments) Looks pretty sane to me, but I'll let Sailesh and Henry be the judge of that http://gerrit.cloudera.org:8080/#/c/2800/2/fe/src/main/java/com/cloudera/impala/authorization/User.java File fe/src/main/java/com/cloudera/impala/authorization/User.java: Line 32: static { Does this mean that changing the auth_to_local config requires an Impala service restart? Is a restart generally required for changing these kind of security configurations? Line 59: } catch (IOException e) { Can you add a comment here that describes at a high-level what is happening in the getShortName() call? Are we communication with a service? Why can it throw an IOE? Throwing the IO exception seems preferable here, then we at least know what happened and could possibly add a sleep/retry mechanism etc. (not that you should do that now) Line 70: public String getShortNameForTesting(String rules) { How about we handle the testing scenario as follows? 1. Add a private user constructor that accepts a name and rules 2. Add a static function createTestUser(name, rules) that calls that constructor 3. Inside createTestUser() add a Preconditions.checkState(RuntimeEnv.isTestEnv()); http://gerrit.cloudera.org:8080/#/c/2800/2/fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java File fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java: Line 1712: // running the query with authtest/[email protected] user which isconverted to user typo: which is -- To view, visit http://gerrit.cloudera.org:8080/2800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
