Alex Behm has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2800/2/fe/src/main/java/com/cloudera/impala/authorization/User.java File fe/src/main/java/com/cloudera/impala/authorization/User.java: Line 32: static { > Thats correct, hdfs requires a restart if we update this configuration. Thanks for clarifying, just wanted to know. Line 59: } catch (IOException e) { > I'll update the comment here. Basically super.getShortName() throws NoMatch IOE seems the most appropriate exception to me, but if it becomes too cumbersome to throw it everywhere I'm ok with re-throwing as an ImpalaException. Line 70: public String getShortNameForTesting(String rules) { > I've considered that but the issue is "rules" are basically static, so if w I see, that's kind of annoying :). Thanks for explaining. I'm fine with this solution, but please do the following: * add a comment saying that the rules are static * do the Preconditions check to make sure we are in a test env * wrap getShortName() in try finally since getShortName() can throw -- To view, visit http://gerrit.cloudera.org:8080/2800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
