Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2800/2/fe/src/main/java/com/cloudera/impala/authorization/User.java
File fe/src/main/java/com/cloudera/impala/authorization/User.java:

Line 59:     } catch (IOException e) {
> IOE seems the most appropriate exception to me, but if it becomes too cumbe
Done.


Line 70:   public String getShortNameForTesting(String rules) {
> I see, that's kind of annoying :). Thanks for explaining. I'm fine with thi
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to