Henry Robinson has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs ......................................................................
Patch Set 3: (6 comments) This patch should also add code to do the mapping in TSasl::getUsername() (see use of FLAGS_force_lowercase_username there), otherwise users will be confused about why the mapping only takes effect for authorization, not for authentication. http://gerrit.cloudera.org:8080/#/c/2800/3/fe/src/main/java/com/cloudera/impala/authorization/AuthorizationChecker.java File fe/src/main/java/com/cloudera/impala/authorization/AuthorizationChecker.java: Line 117: throw new InternalException("Error calling getShortName() for user: " I might be missing context from previous reviews - but why not make this an AuthException? It would prevent leaking another exception type out to all callers. http://gerrit.cloudera.org:8080/#/c/2800/3/fe/src/main/java/com/cloudera/impala/authorization/User.java File fe/src/main/java/com/cloudera/impala/authorization/User.java: Line 36: getAuthenticationMethod What authentication method is this referring to? Does Impala need to set this configuration value? Line 39: defaultRule = "DEFAULT"; Can you add a comment here explaining this logic? Line 62: public String getShortName() throws IOException { Does this method need to exist if it just calls the parent class? (Is the method in the parent class not public?) Line 80: // Do nothing, reset rules and return null. comment doesn't really apply to this line of code. I think it's obvious what the code does anyhow, can just remove it. http://gerrit.cloudera.org:8080/#/c/2800/3/fe/src/main/java/com/cloudera/impala/util/SentryPolicyService.java File fe/src/main/java/com/cloudera/impala/util/SentryPolicyService.java: Line 126: Error calling getShortName() dropRole() shouldn't know what the internals of client.get().dropRole() are, so this exception text here doesn't make sense. -- To view, visit http://gerrit.cloudera.org:8080/2800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
