Dan Hecht has posted comments on this change. Change subject: IMPALA-3166: basic perf support and asm dumps for codegened code ......................................................................
Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/2793/5/be/src/codegen/codegen-symbol-emitter.cc File be/src/codegen/codegen-symbol-emitter.cc: Line 61: open can any of these calls throw? Line 87: lock_guard<SpinLock> perf_map_lock(perf_map_lock_); maybe DCHECK_NE(perf_map_.find(..), perf_map_.end()); to help show there will be no leaked entries in this map. (or dcheck on the erase return value). Line 123: perf_map_lock looks unused. did you mean to DCHECK its locked? http://gerrit.cloudera.org:8080/#/c/2793/5/be/src/codegen/codegen-symbol-emitter.h File be/src/codegen/codegen-symbol-emitter.h: Line 68: Do all processing for the function when i read the comment I assumed this thing would be passed only function symbols, but then reading the code I see it does the filtering. How about: Process the given 'symbo'l with 'size'. For function symbols, append ... or similar. Line 74: held held by caller? Line 83: id_ does the ID have any meaning itself? briefly explain why is it needed and how it's generated or if it's a unique id (unique to what), etc. Line 95: object what object? object file? http://gerrit.cloudera.org:8080/#/c/2793/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 78: "This is not suitable for production use."); please leave a comment explaining why it's not. -- To view, visit http://gerrit.cloudera.org:8080/2793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If25de61e46f4db005956686cddbd4d71a1424528 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
