Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3480: Add query options for min/max filter sizes
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2966/3/be/src/util/bit-util.h
File be/src/util/bit-util.h:

Line 57:   static inline int64_t RoundUpToPowerOfTwo(int64_t v) {
thanks for fixing the name


http://gerrit.cloudera.org:8080/#/c/2966/3/be/src/util/parse-util.cc
File be/src/util/parse-util.cc:

Line 52:     case 'k':
thanks for adding that


-- 
To view, visit http://gerrit.cloudera.org:8080/2966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c13c200a0f1855f38a5da50ca34a737e741868b
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to