Mostafa Mokhtar has posted comments on this change.

Change subject: IMPALA-3480: Add query options for min/max filter sizes
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2966/4/be/src/runtime/runtime-filter.h
File be/src/runtime/runtime-filter.h:

Line 103:   static const int64_t MIN_BLOOM_FILTER_SIZE = 4 * 1024;           // 
4KB
If there are not stats would the filter size default to a 4KB?
Wondering if we should increase the default min size to 1MB.


-- 
To view, visit http://gerrit.cloudera.org:8080/2966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c13c200a0f1855f38a5da50ca34a737e741868b
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-HasComments: Yes

Reply via email to