Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3480: Add query options for min/max filter sizes ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2966/2/be/src/service/query-options.cc File be/src/service/query-options.cc: Line 352: query_options->__set_runtime_filter_min_size(size); > Can't do that here, because we don't know what order the options will be pa you could simply check the set values after your 'if', and then return an error if the set min is > the set max, that should work (meaning only check the actual values in set query_options). -- To view, visit http://gerrit.cloudera.org:8080/2966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c13c200a0f1855f38a5da50ca34a737e741868b Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
