Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3480: Add query options for min/max filter sizes ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2966/2/be/src/service/query-options.cc File be/src/service/query-options.cc: Line 352: query_options->__set_runtime_filter_min_size(size); > I'm not quite following, sorry! Here's the case I'm worried about: i think the is_set flag is off if query_options only has the default min/max. in other words, only check that min <= max if both have been explicitly set. if only one of them is set explicitly, we can adjust the other one that has the default value so that min <= max (e.g., if the explicit max is below the default min, make min = max). -- To view, visit http://gerrit.cloudera.org:8080/2966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c13c200a0f1855f38a5da50ca34a737e741868b Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-HasComments: Yes
