Tim Armstrong has posted comments on this change. Change subject: IMPALA-3166: basic perf support and asm dumps for codegened code ......................................................................
Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/2793/5/be/src/codegen/codegen-symbol-emitter.cc File be/src/codegen/codegen-symbol-emitter.cc: Line 61: open > can any of these calls throw? Nope, you have to explicitly enable exceptions (I initially thought the same thing): http://www.cplusplus.com/reference/ios/ios/exceptions/ I added a comment here, since it's not obvious. Line 87: lock_guard<SpinLock> perf_map_lock(perf_map_lock_); > maybe DCHECK_NE(perf_map_.find(..), perf_map_.end()); Done. Also check that it's not already present when inserting. Line 123: perf_map_lock > looks unused. did you mean to DCHECK its locked? The existence of the lock_guard implies it's locked (unless the caller locked a different lock). Also dcheck that the expected lock is locked. http://gerrit.cloudera.org:8080/#/c/2793/5/be/src/codegen/codegen-symbol-emitter.h File be/src/codegen/codegen-symbol-emitter.h: Line 68: Do all processing for the function > when i read the comment I assumed this thing would be passed only function Done Line 74: held > held by caller? Done Line 83: id_ > does the ID have any meaning itself? briefly explain why is it needed and h It's provided by the caller. Currently it's a fragment instance id, but there's no reason this class really should know the semantics of the ID. Line 95: object > what object? object file? Done http://gerrit.cloudera.org:8080/#/c/2793/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 78: "This is not suitable for production use."); > please leave a comment explaining why it's not. Done. I think some of the issues were fixed (the ever-expanding map file) but the performance impact of the global lock and file operations is probably enough to discourage use. -- To view, visit http://gerrit.cloudera.org:8080/2793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If25de61e46f4db005956686cddbd4d71a1424528 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
