Tim Armstrong has posted comments on this change. Change subject: IMPALA-3166: basic perf support and asm dumps for codegened code ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/2793/6/be/src/codegen/codegen-symbol-emitter.cc File be/src/codegen/codegen-symbol-emitter.cc: Line 127: perf_map_lock > still not sure why this is passed if it's not actually used... Removed http://gerrit.cloudera.org:8080/#/c/2793/6/be/src/codegen/codegen-symbol-emitter.h File be/src/codegen/codegen-symbol-emitter.h: Line 83: The identifier is : /// passed by the caller when the CodegenSymbolEmitter is constructed > I guess I was more looking for a hint at the motivation for why it's needed Done -- To view, visit http://gerrit.cloudera.org:8080/2793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If25de61e46f4db005956686cddbd4d71a1424528 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
