Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic 
more than 2GB.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3067/2/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

Line 1291: break
> Don't just break, please also add an error message.
Error will print later at line 1339. You mean I should print here as well?


Line 1293: update_req.__set_is_delta(true);
> I don't think delta indicates that the updates are performed in batches.
none delta will clear impalad's cache and create a new one.
anything after the first update(in this if clause) should be delta.


-- 
To view, visit http://gerrit.cloudera.org:8080/3067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to