Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/3067/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 196: int64_t > uint64_t Done Line 1247: Process any updates > Update the function comment to indicate that large updates are performed in Done Line 1251: int64_t > uint64_t Done Line 1282: // IMPALA-3499 batch sending catalog update. This also work around IMPALA-3494. : // The limit is selected such that topic_deletions can be appended without exceeding : // 2GB java byte array limit, which simplify the code a lot. > Remove comment. Done Line 1286: INFO > I think WARN is more appropriate. Done Line 1287: update_size > I don't think that is correct. The catalog update size is update_size - len Done -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
