Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3067/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1291: break > The logic now is confusing and perhaps hides a number of bugs. Previously, 1. this break sends execution to line 1303, so what happened next is that we will push something to removed_objects, but impala wont send this. (next send is at line 1336). I can put more checks but those may not be necessary. what do you think? 2. Yes. front end will have partially updated metadata(not sure what do you mean by inconsistent state). but it also requests a full update next time, which will overwrite everything. that will be consistent because everything already updated is legit. Line 1293: update_req.__set_is_delta(true); > How do you know this isn't the first update? if this is the first update then is_delta will be set to false at line1250. this place only reset that to prevent overwriting. -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
