Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3499: Frontend cannot deserialize catalog-update topic more than 2GB. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3067/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1291: break > 1. this break sends execution to line 1303, so what happened next is that w Wrt #1, I'd prefer the actions performed after a call that returns status to be immediately after that call and not 40 lines later. Wrt #2. This is a bit tricky. First of all, we currently don't have a way to test it. Second, I am not sure the entries will be overridden. We override an entry if its version is older than the one we receive. Additionally, when we update the local cache we also change some metadata (see L1353). With the scenario I've described you may end up with a case where the catalog cache has some entries but the catalog_update_info_ hasn't been updated. This is an inconsistent state which we should try to avoid. -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
