Jim Apple has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/1/src/hs2client/test-util.h File src/hs2client/test-util.h: Line 31: __status__ I view this as pretty risky - names starting with double underscore are reserved for the compiler and standard libraries. Any reason you can't use just plain "status" here, rather than "__status__"? -- To view, visit http://gerrit.cloudera.org:8080/3068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8 Gerrit-PatchSet: 1 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
