Matthew Jacobs has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File src/hs2client/test-util.h: Line 31: status > Seems like expect_ok_fn is the most guaranteed to be correct, so I'll go wi Jim, is this what you had in mind? One thing I don't like about this approach is that it will result in printing 2 line numbers, since EXPECT_TRUE() also prints a line number. I think we should just keep it simple like it was before but with a better name (see my first comment w/ the example from Kudu). I'm fine with putting the line number in the status if you think that's safe and a normal thing to do, but this is a pretty common pattern I think, no? -- To view, visit http://gerrit.cloudera.org:8080/3068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8 Gerrit-PatchSet: 2 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
