Matthew Jacobs has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. ......................................................................
Patch Set 2: (1 comment) Thanks for the tip, Jim. We should fix this in Impala as well then. http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File src/hs2client/test-util.h: Line 31: status Status seems likely to conflict. Perhaps we should follow Kudu's example and go with something like _s. Here's some background info: http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier #define KUDU_RETURN_NOT_OK(s) do { \ ::kudu::Status _s = (s); \ if (PREDICT_FALSE(!_s.ok())) return _s; \ } while (0); -- To view, visit http://gerrit.cloudera.org:8080/3068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8 Gerrit-PatchSet: 2 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
