Thomas Tauber-Marshall has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File src/hs2client/test-util.h: Line 31: status > Silly question: why can't this be a function, rather than a macro? Defining them as macros is more consistent with the gtest EXPECT_TRUE/FALSE macros, and it also results in better error messages since the failure will show the actual line number in the test, rather than always showing the same line number in the EXPECT_OK function. -- To view, visit http://gerrit.cloudera.org:8080/3068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8 Gerrit-PatchSet: 2 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
