Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2932/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 499: f->pending_count = filter.is_broadcast_join ? 1 : num_hosts; > this will also get set to 1 even for a local-only filter, and probably show could you take a close look at what's going on here? we need to make sure we don't output what look like error messages to the profile, otherwise we'll end up making more work for ourselves (with questions to answer, etc.) -- To view, visit http://gerrit.cloudera.org:8080/2932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2ce4e579a30616c469312a4e658140d317507b Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
