Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2932/5/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 150: const auto& target = filter.targets[it->second]; use type http://gerrit.cloudera.org:8080/#/c/2932/5/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 518: const auto& tFilterTarget = filter.targets[it->second]; please don't use auto here, this isn't an stl iterator (and having an explicit type makes the code easier to read) -- To view, visit http://gerrit.cloudera.org:8080/2932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2ce4e579a30616c469312a4e658140d317507b Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
