Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/2932/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 499: f->pending_count = filter.is_broadcast_join ? 1 : num_hosts; > I don't think we should change anything here. pending_count indicates how m we need to change the output to clearly indicate that there isn't anything wrong. let's make this clearer than N/A (which can be interpreted to mean 'not available', ie, something is missing). as for the code: you should set the pending count to 0 here to make clear that we're really not waiting for something to arrive. and UpdateFilter() should dcheck that it doesn't see updates for local-only filters. http://gerrit.cloudera.org:8080/#/c/2932/4/be/src/runtime/runtime-filter.cc File be/src/runtime/runtime-filter.cc: Line 98: bool has_local_targets = false; > Why do you say it only needs to have one? A filter can have many local and i meant it only needs to have a single remote target in order for the filter to get sent to the coordinator (and it only needs a single local target to require the short-circuit path) -- To view, visit http://gerrit.cloudera.org:8080/2932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2ce4e579a30616c469312a4e658140d317507b Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
