Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2956: Filters should be able to target multiple scan nodes ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/2932/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 499: f->pending_count = filter.is_broadcast_join ? 1 : num_hosts; > we need to change the output to clearly indicate that there isn't anything Good point. Did that. http://gerrit.cloudera.org:8080/#/c/2932/4/be/src/runtime/runtime-filter.cc File be/src/runtime/runtime-filter.cc: Line 98: bool has_local_targets = false; > i meant it only needs to have a single remote target in order for the filte Got it. Thanks. Done -- To view, visit http://gerrit.cloudera.org:8080/2932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2ce4e579a30616c469312a4e658140d317507b Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
