Dan Hecht has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3109/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 897: state_->batch_size() > Maybe cache this, or just use a sensible constant like 1024? Maybe it doesn or you could make it a count down so that it's only loaded on the unlikely path: --comparison_count_; if (comparison_count_ == 0) { .. comparison_count_ = state->batch_size(); } maybe rename comparison_count_ if you do that (and even if you don't to give some clue it's related to FreeLocalAllocations()). -- To view, visit http://gerrit.cloudera.org:8080/3109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id658243d4ffa9dcdbf4e867db0bb3e8d161af086 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
