Michael Ho has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. ......................................................................
Patch Set 4: The perf difference seems to be within the noise: +-------------------+-----------------------+---------+------------+------------+----------------+ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +-------------------+-----------------------+---------+------------+------------+----------------+ | TARGETED-PERF(15) | parquet / none / none | 5.71 | +0.53% | 4.50 | +0.63% | +-------------------+-----------------------+---------+------------+------------+----------------+ +-------------------+--------------------------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+ | Workload | Query | File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters | +-------------------+--------------------------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+ | TARGETED-PERF(15) | primitive_orderby_bigint | parquet / none / none | 2.20 | 2.18 | +0.78% | 1.84% | 2.03% | 1 | 5 | | TARGETED-PERF(15) | primitive_orderby_all | parquet / none / none | 9.22 | 9.18 | +0.47% | 0.95% | 1.42% | 1 | 5 | +-------------------+--------------------------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+ -- To view, visit http://gerrit.cloudera.org:8080/3109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id658243d4ffa9dcdbf4e867db0bb3e8d161af086 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
