Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-3332: Free local allocations in sorter. ......................................................................
IMPALA-3332: Free local allocations in sorter. Sorter can have runaway memory consumption as it never frees local allocations made in comparator_.Less(). In addition, it doesn't check for errors generated during expression evaluation so it may keep sorting even after failures have occurred. This change fixes the problem by freeing local allocations for every n invocations of comparator_.Less() where n is the row batch size specified in the query options. Various error checks are also added to return early if any error is encountered. Change-Id: Id658243d4ffa9dcdbf4e867db0bb3e8d161af086 --- M be/src/runtime/sorter.cc M be/src/util/tuple-row-compare.h M testdata/workloads/functional-query/queries/QueryTest/sort.test 3 files changed, 115 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/09/3109/3 -- To view, visit http://gerrit.cloudera.org:8080/3109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id658243d4ffa9dcdbf4e867db0bb3e8d161af086 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
