Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3332: Free local allocations in sorter. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3109/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 353: Less > I hope you don't mind if I keep it as Less for two reasons: Sure, I don't feel strongly. #1 makes sense, though I don't think the fact that this wraps something else is the most important thing here, but rather that the class interface is something of a cohesive abstraction, i.e. methods on a class should make sense in the context of itself. The fact this wraps comparator_.Less() is more of an implementation detail now that gets hoisted up to the top-level abstraction. Anyway, I don't really feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/3109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id658243d4ffa9dcdbf4e867db0bb3e8d161af086 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
