Matthew Jacobs has posted comments on this change. Change subject: Fix hs2client EXPECT_OK macro. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3068/2/src/hs2client/test-util.h File src/hs2client/test-util.h: Line 31: status > MJ, this IS what I had in mind, and I also share your concern about the lin I'm not *too* concerned about this in general since it's pretty common and any naming collisions would result in a compile-time error, but that seems fine to me as long as those are portable pre-processor directives (I think they are from a quick search). -- To view, visit http://gerrit.cloudera.org:8080/3068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If44402809dc4e76ec40597caa65e40a202b241c8 Gerrit-PatchSet: 2 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
