Dan Hecht has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3154/1/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 565: TIMESTAMP_PRECISION TIMESTAMP_SCALE (to be consistent with decimal terminology, and reword the comment above) Line 574: * can't these integer multiplies overflow? is there a reason that can't happen? Line 599: TimestampValue tv(whole_pt, fract_pt); what is the effective (precision, scale) for TIMESTAMP? aren't there some decimal values that can't be represented? what should we do in those cases? For DECIMAL to DECIMAL it looks like we issue a warning and return null() (see RETURN_IF_OVERFLOW uses). Have we defined the behavior in those cases? -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
