Dan Hecht has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3154/1/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 574: * > I meant doing something like this: http://github.mtv.cloudera.com/CDH/Impal Yeah, okay. GetScaleMultiplier is pretty cheap - just does an array index. Line 599: TimestampValue tv(whole_pt, fract_pt); > I added some new test cases. Are you suggesting to add a comment to every e No, I didn't mean code comments. I meant in the gerrit review add a comment if any new test cases return different results before and after so we know which cases behave differently when reviewing the code. -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
