Tim Armstrong has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3154/1//COMMIT_MSG Commit Message: Line 14: slightly slower than the old one (96 seconds vs 70 seconds). This issue I think the scale/precision should already be substituted by codegen though (the Expr::GetConstant()) function is a magic function that we replace with the constant value during codegen. It would be good to understand why it's slower, although obviously it's better to be slightly slower and correct :) -- To view, visit http://gerrit.cloudera.org:8080/3154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
